Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement]: Remove configure from main branches, have release process produce configure for tag and tarball #70

Open
jcolp opened this issue May 10, 2023 · 3 comments
Labels
improvement support-level-core Functionality with core support level

Comments

@jcolp
Copy link
Member

jcolp commented May 10, 2023

Improvement Description

Per discussion on the asterisk-dev mailing list to reduce churn when configure changes are made, and to reduce our conflicts if we have multiple configure changes going on the following will be done:

  1. 'configure' will be removed from the mainline branches (18, 20, master)
  2. Documentation will be updated with instructions for running bootstrap.sh in this scenario
  3. Makefile will state that configure needs to be run if it has not already been done and is invoked
  4. The release process will be updated to run bootstrap.sh and produce the configure script, this configure script will be placed in the tag and release tarball
  5. The CI process will be updated to include running bootstrap.sh as part of the build process
  6. Add to .gitignore in mainline branches
@jcolp jcolp added improvement triage support-level-core Functionality with core support level and removed triage labels May 10, 2023
@gtjoseph
Copy link
Member

One problem...
If you're on 18 with configure removed and you run bootstrap, then switch to releases/18 git overwrites your local configure as it should. if you switch back to 18 however, configure is deleted since it's not in that index and you have to run bootstrap again.

@jcolp
Copy link
Member Author

jcolp commented May 10, 2023

I don't see that as a problem. If you're changing to any mainline branch you should rerun bootstrap.sh

@lathama
Copy link
Contributor

lathama commented May 11, 2023

Add to gitignore also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement support-level-core Functionality with core support level
Projects
None yet
Development

No branches or pull requests

3 participants