Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pjsip: add tests for multirate 2833 #23

Merged
merged 1 commit into from
May 16, 2024
Merged

pjsip: add tests for multirate 2833 #23

merged 1 commit into from
May 16, 2024

Conversation

mbradeen
Copy link
Contributor

@mbradeen mbradeen commented Nov 28, 2023 •
edited

Demonstrate appropriate handling of non 8K RFC 2833 digits

Proposed addition of four categories of tests

  1. Test that Asterisk offers the correct sdp for opus and ulaw when RFC 2833 is enabled
  2. Test that Asterisk creates the correct responses for opus and ulaw when RFC 2833 is enabled
  3. Test that Asterisk is able to read RFC 2833 digits embedded in both an opus stream and an ulaw stream.
  4. Test that Asterisk generates the correct payload type for the dtmf digits in the rtp stream

Requires: #700

@mbradeen mbradeen closed this Nov 28, 2023
@mbradeen mbradeen reopened this Nov 28, 2023
@mbradeen mbradeen marked this pull request as draft November 28, 2023 16:54
@github-actions GitHub Actions
Copy link

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the [Create a Pull Request](https://docs.asterisk.org/Development/Policies-and-Procedures/Code-Contribution) process.

If you don't want it cherry-picked, please add a "cherry-pick-to: none" comment so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add "cherry-pick-to: none".

@mbradeen
Copy link
Contributor Author

mbradeen commented Nov 28, 2023 •
edited by gtjoseph

cherry-pick-to: 18
cherry-pick-to: 20
cherry-pick-to: 21

@mbradeen mbradeen changed the title pjsip: add tests for multirate 2833 DRAFT pjsip: add tests for multirate 2833 Apr 23, 2024
@mbradeen mbradeen marked this pull request as draft April 29, 2024 18:33
@mbradeen mbradeen marked this pull request as ready for review April 30, 2024 17:01
@mbradeen mbradeen force-pushed the dtmf-interop branch 2 times, most recently from 4ea1da7 to f20c4e4 Compare April 30, 2024 18:07
@mbradeen
pjsip: add tests for multirate RFC 2833 dtmf
3f2bcd6 
Demonstrate appropriate handling of non 8K
2833 digit sdp offers.

Four categories of tests

Test that Asterisk offers the correct sdp for opus and ulaw when
RFC 2833 is enabled

Test that Asterisk creates the correct responses for opus and ulaw
when RFC 2833 is enabled

Test that Asterisk is able to read RFC 2833 digits embedded in both
an opus stream and ulaw stream.

Test that Asterisk generates the correct payload type for the RFC
2833 digits in the rtp stream
@github-actions github-actions bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-passed Cherry-Pick checks passed and removed cherry-pick-test cherry-pick-testing-in-progress Cherry-Pick tests in progress labels May 13, 2024
@asterisk-org-access-app asterisk-org-access-app bot merged commit 3d7cbec into asterisk:master May 16, 2024
23 checks passed
@github-actions GitHub Actions
Copy link

Successfully merged to branch master and cherry-picked to ["18","20","21"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcolp jcolp jcolp approved these changes

Assignees
No one assigned
Labels
cherry-pick-checks-passed Cherry-Pick checks passed pr-submit-tests-passed pre-merge-checks-passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbradeen @jcolp @gtjoseph