-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pjproject 2.12.1 #11
Add pjproject 2.12.1 #11
Conversation
We have to test before accepting 2.12.1. |
Actually, I'm going to re-open this PR but can you squash down the commits into 1? |
@gtjoseph i really have no idea how to do this |
@gtjoseph you can squash it when merging the pull request. The 'merge pull request' button has a drop down with a 'squash and merge' option. |
Yeah but I'd rather see the final result before I merge and @silentindark 's fork will be out of date. @silentindark Here's what you can do...
Delete the two lines that create and delete the test and change "pick" to "fixup" (or just "f") for all but the first line...
Save and close your editor. |
@gtjoseph Thank you so much for help! |
That's what the Files changed tab is for. I don't follow the "out of date" comment. |
pjproject/2.12.1/MD5SUM.TXT
Outdated
@@ -0,0 +1,3 @@ | |||
7f80ba8e1540853f959be6be7912a150 pjproject-2.12.1.tar.bz2 | |||
339fcf1373276184fbdb821f75a1efbf pjproject-2.12.1.tar.gz | |||
e086683e3441be6e609fc4ce8cf2757f pjproject-2.12.1.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checksums for the tar.gz and zip files don't match what I get when I run md5sum...
a0250481bb082d553ae671bee7519d1b pjproject-2.12.1.tar.gz
94823f8556403b72e47486089c1cad96 pjproject-2.12.1.zip
The bz2 and sha256 checksums are OK though.
@seanbright This is what I meant. It would have been hard to make changes if @silentindark hadn't squashed the commits on his end because the commits added, deleted then added files again. He doesn't need to squash the commit to fix the checksums though because at least now there's a good base commit for the pull request. I can squash them as I merge them. |
Fixed checksums for the tar.gz and zip files
@gtjoseph You are right, I fixed checksums for the tar.gz and zip files |
You're good. Squashing the original commits created a good base so this one I can squash as I merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, thanks!
More information: https://github.com/pjsip/pjproject/releases/tag/2.12.1 Pull request to third-party asterisk/third-party#11 ASTERISK-30050 Change-Id: Icb4e86d4b85ef9b975355c91f3ed56a50b51c6bd
More information: https://github.com/pjsip/pjproject/releases/tag/2.12.1 Pull request to third-party asterisk/third-party#11 ASTERISK-30050 Change-Id: Icb4e86d4b85ef9b975355c91f3ed56a50b51c6bd
More information: https://github.com/pjsip/pjproject/releases/tag/2.12.1 Pull request to third-party asterisk/third-party#11 ASTERISK-30050 Change-Id: Icb4e86d4b85ef9b975355c91f3ed56a50b51c6bd
More information: https://github.com/pjsip/pjproject/releases/tag/2.12.1 Pull request to third-party asterisk/third-party#11 ASTERISK-30050 Change-Id: Icb4e86d4b85ef9b975355c91f3ed56a50b51c6bd
More information: https://github.com/pjsip/pjproject/releases/tag/2.12.1 Pull request to third-party asterisk/third-party#11 ASTERISK-30050 Change-Id: Icb4e86d4b85ef9b975355c91f3ed56a50b51c6bd
More information:
https://github.com/pjsip/pjproject/releases/tag/2.12.1