Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #3 #6 #16 .
asteroid.engine.system.System
. Automatize the interface while keeping core objects (model, optimizer, loss and data) separated. Keep everything overwritable.Container
(trying to cover all forwards is not feasible),Solver
(lightning will do training better than us) andSubModule
(saving and loading are solved by the above).About
pytorch-lightning
:Low priority : dig deeper in the features to give sensible default values to
asteroid
users.