Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[egs] Fix the issue regarding X-UMX when receiving a mono audio as the input #571

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

r-sawata
Copy link
Contributor

@r-sawata r-sawata commented Nov 4, 2021

Addressed the following issue pointed out by Marius via Slack:

Marius Miron 12:01 AM
I think there is a bug in XUMX multidomain loss. whenever you do 2 * i : 2 * i + 2, you should actually do n_channel * i : n_channel * i + n_channel
otherwise it fails for monaural. what do you think?

Marius Miron 12:06 AM
and also (in multidomain) this must be _Spectrogram(spec_power=spec_power, mono=False), otherwise it mixes two sources in mono

@mpariente
Copy link
Collaborator

Thanks @r-sawata !

@JorisCos would you like to have a look at unit tests and docs build? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants