Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Preparing metadata (pyproject.toml) did not run successfully #35

Closed
szhan opened this issue Apr 5, 2024 · 6 comments
Closed

Comments

@szhan
Copy link
Collaborator

szhan commented Apr 5, 2024

I'm encountering the error in the title when trying to do PRs #31 and #34. I'm not sure what is going on. The pytests pass, and didn't even touch pyproject.toml.

@jeromekelleher
Copy link
Collaborator

Hmm, looks like the Actions infrastructure is a bit out of date, probably some versions of various packages have moved on. Would need a bit of cleanup.

@astheeggeggs, what's your take here? Shall we tidy things up and get stuff running again? I think we could make things a bit simpler, and just to the minimal "lint passes, tests pass" CI setup.

@astheeggeggs
Copy link
Owner

Sure, simple sounds good to me. What needs ripping out?

@szhan
Copy link
Collaborator Author

szhan commented Apr 16, 2024

It looks like nox doesn't like a host of things being defined outside of pyproject.toml. For example,

/tmp/pip-build-env-gh79cjfj/overlay/lib/python3.8/site-packages/setuptools_scm/git.py:163: UserWarning: "/home/runner/work/lshmm/lshmm" is shallow and may cause errors
        warnings.warn(f'"{wd.path}" is shallow and may cause errors')
      /tmp/pip-build-env-gh79cjfj/overlay/lib/python3.8/site-packages/setuptools_scm/_integration/setuptools.py:90: UserWarning: version of None already set
        warnings.warn(f"version of {dist_name} already set")
      /tmp/pip-build-env-gh79cjfj/overlay/lib/python3.8/site-packages/setuptools/config/_apply_pyprojecttoml.py:76: _MissingDynamic: `readme` defined outside of `pyproject.toml` is ignored.
      !!
      
              ********************************************************************************
              The following seems to be defined outside of `pyproject.toml`:
      
              `readme = '# lshmm\ncode to run Li and Stephens\n'`
      
              According to the spec (see the link below), however, setuptools CANNOT
              consider this value unless `readme` is listed as `dynamic`.
      
              https://packaging.python.org/en/latest/specifications/pyproject-toml/#declaring-project-metadata-the-project-table
      
              To prevent this problem, you can list `readme` under `dynamic` or alternatively
              remove the `[project]` table from your file and rely entirely on other means of
              configuration.
              ********************************************************************************

@szhan
Copy link
Collaborator Author

szhan commented Apr 16, 2024

Oops, didn't mention that it happens when it runs nox -s lint.

@jeromekelleher
Copy link
Collaborator

Closed by #36

@szhan
Copy link
Collaborator Author

szhan commented Apr 17, 2024

I was expecting that this issue would be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants