This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Add second instance support #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, I've closed the other PR. However we need to finish the JS PR first, as we need to update astilectron version before merging this PR. Do you feel like finishing the JS PR as well? |
|
Could you change the astilectron version to |
Done :) |
|
FYI I've created a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the Go-side of #284 (comment)
This is a follow up to #287, which had an almost working version of second instance support (it just had a slight mismatch of types between JS and Go).
I tested by modifying the demo to listen to this event and log when it happened.
Demo changes are available here, I can PR them if you would like:
https://github.com/Joe-Improbable/go-astilectron-demo
Let me know what you think