webvtt,srt: Tolerate edge whitespace (and print line numbers on error) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good. Actually could you add the same change to And I'm open for a PR displaying line numbers in errors. Cheers |
|
Okay, cool! This is kind of a weekend/side project for me, so it might be a few days, but I'll get around to it (unless someone beats me to it). Thanks for the helpful lib. |
|
@asticode I just put them both in this one, since they're small changes :P Hope this is good to go, thanks! |
mholt
changed the title
|
Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm by no means an expert of WebVTT format but this fixed a parsing problem for me. Feel free to reject if it's a bad change, or improve it or whatever you'd like.
PS. It'd be really helpful to output the line number when an error is encountered. Would you be open to a PR for that?