Improve STL GSIBlock write #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Tests seem broken, you'll need to fix them as well. Let me know if you need some guidance for that 👍 |
|
Oops sorry! This should do the trick. |
|
Cheers! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows astisub to write a STL file with a GSIBlock closer to the STL file read, by adding the copy of the fields revisionNumber, translatedEpisodeTitle, translatedProgramTitle, translatorContactDetails and translatorName to/from the Subtitles.Metadata. Also the translatedEpisodeTitle and translatedProgramTitle were in reverse order in the output block (I checked in the EBU spec).
Why? I'm investigating why the write to STL doesn't seem to produce a valid STL (valid tcin/tcout but no text when converting that STL back to WebVTT), so I try to get the
convert -i in.stl -o out.stlto produce a close (perfect?) copy, so I'm starting with the GSIBlock ...