Prefer warn instead of diag when notice unexpected external access #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good! |
The message `Unexpected external access` is just a warning. If we used CORE::warn, we assume that no warnings are found with a module such as Test::Warnings
|
@astj Please review this 🙏 |
|
@aereal Thanx!!! LGTM 😄 |
|
💨 |
aereal
added a commit
that referenced
this pull request
Jan 21, 2016
Prefer warn instead of diag when notice unexpected external access
astj
added a commit
that referenced
this pull request
Jan 23, 2016
Changelog diff is:
diff --git a/Changes b/Changes
index 0a84138..4ad2ad5 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,9 @@ Revision history for Perl extension Test-WWW-Stub
{{$NEXT}}
+0.05 2016-01-23T14:13:37Z
+ - Prefer warn instead of diag when notice unexpected external access. (#12, thanks to aereal)
+
0.04 2015-12-16T09:32:08Z
- Fix a bug that #unstub doesn't work with older LWP::Protocol::PSGI. (#11, thanks to aereal)
|
@aereal Released as 0.05!!!!! http://twitter.com/cpan_new/status/690901819992604672 |
astj
added a commit
that referenced
this pull request
Mar 13, 2016
Changelog diff is:
diff --git a/Changes b/Changes
index 4ad2ad5..2f3acde 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,9 @@ Revision history for Perl extension Test-WWW-Stub
{{$NEXT}}
+0.06 2016-03-13T16:00:45Z
+ - Declare dependency on Guard. (#14, thanks to eserte)
+
0.05 2016-01-23T14:13:37Z
- Prefer warn instead of diag when notice unexpected external access. (#12, thanks to aereal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using
warnwe can use Test::Warnings to make tests failure and immediately fix them.