Update CenCols notebook #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Joe,
Thanks for the example, I went through and this works now.
I'm not entirely sure what the problem was before, as you said you did try some other things that weren't reflected in the notebook.
In the notebook, the wavelength ranges for the Pholus SED were definitely not going quite as red as the filters, so that was why nans were coming up. The max wavelength for the filters was (by default) 1150, while your sed went down to about 1103.
I reworked some of the notebook a little bit, basically just ensuring that the wavelength extensions for the sed went far enough into the red (you also have to be careful about numpy.arange cutting off a little bit earlier than expected, sometimes).
I was able to calculate magnitudes at the end, so hopefully this works for you!