Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with the 'sort'-extender. #132

Closed
Kanaye opened this issue Feb 12, 2016 · 0 comments
Closed

Issues with the 'sort'-extender. #132

Kanaye opened this issue Feb 12, 2016 · 0 comments

Comments

@Kanaye
Copy link
Collaborator

Kanaye commented Feb 12, 2016

The sort extender does not get bound to the View-context.
Updates of 'external' (not collection related)-observables will cause the sort function to run, but the .view will not get updated.
collection.extend('sort', 'myField'); only works with numeric values.
Kanaye pushed a commit to Kanaye/jsblocks that referenced this issue Feb 13, 2016
Fixed some bugs in the sort-extender.
64f69a9 
Closes astoilkov#132.
Also fixed a bug in array-observable.move().
@Kanaye Kanaye mentioned this issue Feb 14, 2016
Merged
astoilkov added a commit that referenced this issue Feb 14, 2016
@astoilkov
Merge pull request #133 from Kanaye/fix-#132
8e602c3 
Fixed issues with the sort-extender described in #132.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kanaye