Investigate potential remaining items for Chai v4 support

[astorije]

A long, long time ago, I listed a few things to look at to be ready for Chai v4 here: #69 (comment)

Need to wrap these.

[ghost]

Is there any update on version 2?

[astorije]

Hi @probedb! I stiiiill haven't finished this, I'm sorry. I'm almost there, there are a couple things left I want to look at before publishing this. Sorry about this!

In the meantime, I have just published v2.0.0-alpha.2 with the latest master. It is compatible with Chai v4 and requires Node v6+. Could you try it (npm install --save-dev chai-immutable@next or yarn add --dev chai-immutable@next) and let me know if you notice anything wrong with it?

Thanks!

[ghost]

@astorije no problem, I'll give it a try tomorrow when I have chance to test it :)

[astorije]

@probedb, any luck?

[astorije]

Hey @probedb, I have just released v2.0.0-rc.2 which hopefully is the last step before full Chai v4 support (finally!). Mind giving it a shot and letting me know if it works as expected for you?

[ghost]

Sorry @astorije ended up busy! I've updated to 2.0.0-rc.2 and chai 4.1.2 and the only issues I have are: when doing:

expect(callback.args[0][0]).to.eql(new Error('something went wrong'))

I get:

AssertionError: expected [Error: something went wrong] to deeply equal [Error: something went wrong]
      + expected - actual

But I've had this before with error objects, there's 13 errors like this after the update.

[astorije]

I suspect this is unrelated to chai-immutable (or immutable itself), therefore not with the v2 either. Do you concur?

[ghost]

@astorije yep I'd agree, I believe it's due to the way the object is created for comparison and something has changed in Chai.