.equal now checks for isImmutable instead of isIterable #213
Conversation
|
Great stuff, thanks @gugu! |
|
@astorije I updated immutable dependency version. Is it okay? It will test both branches |
|
Hey @gugu, thanks for following up! |
|
Hey @gugu, do you have any plans to finish this? I'd love to merge your work :) |
|
@astorije done, I'll check build results tomorrow |
.travis.yml
Outdated
| - 'if [ "$IMMUTABLE_VERSION" ]; then npm install immutable@$IMMUTABLE_VERSION; fi' | ||
| env: | ||
| - IMMUTABLE_VERSION=3 | ||
| - IMMUTABLE_VERSION=4.0.0-rc.12 |
There was a problem hiding this comment.
Can this accept a broader version, such as IMMUTABLE_VERSION=4 or something?
There was a problem hiding this comment.
only after release, this version does not follow semver :(
There was a problem hiding this comment.
Yeah I realized that, that's why I went with ^4.0.0-rc. When 4 gets stable, I'll revise that.
|
Very cool, thanks for keeping up with me, @gugu, I think we're getting there! :) |
|
@astorije I fixed issues, but I don't know why does appveyor fails |
…config file a little
|
Yes, that's okay |
|
Thank you! 🙏 |
|
This has now be released as part of v2.1.0. Thanks again! |
.equal now checks for isImmutable instead of isIterable
Copies isImmutable function from #83, but no conflicts and check for isImmutable only for .equal. Other places have valid checks for isIterable (.empty or .size is not available in Record)