Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precisions around deep equality #25

Merged
merged 3 commits into from
Oct 27, 2015
Merged

Precisions around deep equality #25

merged 3 commits into from
Oct 27, 2015

Commits on Oct 18, 2015

  1. Add a mention to #24 in the README 

    Both for TDD and BDD styles

This explains that immutable structures should only contain other
immutable structures when used against `.equal()`, or the result
is likely to be unexpected.
    @astorije
    astorije committed Oct 18, 2015
    Configuration menu
    Copy the full SHA
    10b1827 View commit details
    Browse the repository at this point in the history

  2. Add .eql() as an alias of .equal() 

    This is only true when inner elements are all immutable, but #24 shows
up that it should always be the case anyway.
    @astorije
    astorije committed Oct 18, 2015
    Configuration menu
    Copy the full SHA
    542f181 View commit details
    Browse the repository at this point in the history

  3. Add tests for deep equal (in)equality 

    For both TDD and BDD styles
    @astorije
    astorije committed Oct 18, 2015
    Configuration menu
    Copy the full SHA
    e442ffc View commit details
    Browse the repository at this point in the history