Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upstream port] feat: merge dependencies for better error messages (#163) #14

Closed
wants to merge 2 commits into from

Conversation

konstin
Copy link
Member

@konstin konstin commented Dec 18, 2023

Cherry-pick pubgrub-rs#163 from upstream


  • bad error test

  • feat: merge direct dependencies

  • separate function for clearer documentation

  • Update doc comments for merge_dependency

  • Rename merge_dependency into merge_dependants

  • Use american english dependent instead of dependant

  • Rename dependencies into merged_dependencies

  • Typo mergeed -> merged

* bad error test

* feat: merge direct dependencies

* separate function for clearer documentation

* Update doc comments for merge_dependency

* Rename merge_dependency into merge_dependants

* Use american english dependent instead of dependant

* Rename dependencies into merged_dependencies

* Typo mergeed -> merged

---------

Co-authored-by: Matthieu Pizenberg <matthieu.pizenberg@gmail.com>
@konstin konstin requested a review from zanieb December 18, 2023 13:01
@zanieb
Copy link
Member

zanieb commented Dec 18, 2023

@konstin we just rebase main then force push rather than cherry-pick with a pull request

@konstin
Copy link
Member Author

konstin commented Dec 18, 2023

@konstin konstin closed this Dec 18, 2023
@konstin konstin deleted the konsti/upstream-163 branch March 13, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants