Automatically ignore unsupported command-line arguments #145
+55
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/args
branch
2 times, most recently
from
1e62f5d
to
bda5435
Compare
charliermarsh
force-pushed
the
charlie/args
branch
from
bda5435
to
d696943
Compare
zanieb
reviewed
Oct 7, 2023
Comment on lines
+132
to
+133
| # "--stdin-filename", | ||
| # "--format", |
There was a problem hiding this comment.
@charliermarsh why are these commented out?
There was a problem hiding this comment.
Because they aren’t flags, they’re positional arguments, so they’re followed by another argument. I figured this wasn’t worth handling since they would error anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69.
Closes astral-sh/ruff-vscode#174.