Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused showNotification setting #149

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Remove unused showNotification setting #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ the following settings are supported:
| path | `[]` | Path to a custom `ruff` executable, e.g., `["/path/to/ruff"]`. |
| interpreter | `[]` | Path to a Python interpreter to use to run the linter server. |
| run | `onType` | Run Ruff on every keystroke (`onType`) or on save (`onSave`). |
| showNotification | `off` | Setting to control when a notification is shown. |
| organizeImports | `true` | Whether to register Ruff as capable of handling `source.organizeImports` actions. |
| fixAll | `true` | Whether to register Ruff as capable of handling `source.fixAll` actions. |

Expand Down
4 changes: 0 additions & 4 deletions ruff_lsp/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@ class UserSettings(TypedDict, total=False):
run: Literal["onSave", "onType"]
"""Run Ruff on every keystroke (`onType`) or on save (`onSave`)."""

showNotifications: Literal["off", "always", "onWarning"]
"""Setting to control when a notification is shown."""

organizeImports: bool
"""Whether to register Ruff as capable of handling `source.organizeImports`."""

Expand Down Expand Up @@ -943,7 +940,6 @@ def _default_settings() -> UserSettings:
"interpreter": GLOBAL_SETTINGS.get("interpreter", [sys.executable]),
"importStrategy": GLOBAL_SETTINGS.get("importStrategy", "fromEnvironment"),
"run": GLOBAL_SETTINGS.get("run", "onType"),
"showNotifications": GLOBAL_SETTINGS.get("showNotifications", "off"),
"organizeImports": GLOBAL_SETTINGS.get("organizeImports", True),
"fixAll": GLOBAL_SETTINGS.get("fixAll", True),
}
Expand Down