Always write empty fixes on Ruff >= 0.1.6 #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Nov 10, 2023
| @@ -140,10 +140,10 @@ class VersionModified(NamedTuple): | |||
| # Require at least Ruff v0.0.291 for formatting, but allow older versions for linting. | |||
| VERSION_REQUIREMENT_FORMATTER = SpecifierSet(">=0.0.291,<0.2.0") | |||
| VERSION_REQUIREMENT_LINTER = SpecifierSet(">=0.0.189,<0.2.0") | |||
| # Version requirement for use of the "ALL" rule selector | |||
| VERSION_REQUIREMENT_ALL_SELECTOR = SpecifierSet(">=0.0.198,<0.2.0") | |||
There was a problem hiding this comment.
Turns out this is now unused.
charliermarsh
changed the title
charliermarsh
force-pushed
the
charlie/empty
branch
2 times, most recently
from
fb4e633
to
99469b0
Compare
dhruvmanila
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We can avoid the safeguard we introduced in #317 for newer Ruff versions, since Ruff will now avoid writing empty output for excluded files (see: astral-sh/ruff#8596).
Closes #267.
Test Plan
I tested this with a local debug build. Now, when I "Fix all" on a non-excluded file with
import os, it does properly get removed, while running "Format" or "Fix all" on an excluded file leaves the contents untouched.