Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff fromEnvironment (vscode extension) not found under windows #51

Conversation

FrancescElies
Copy link
Contributor

@FrancescElies FrancescElies commented Jan 2, 2023

Problem: vscode with ruff strategy fromEnvironment throws the following error under windows

        Interpreter executable (./venv/py310/Scripts/ruff) not found; falling back to bundled executable

Sadly under windows ruff has the .exe extension, thus not found.

This pr fixes that

Interpreter executable (./venv/py310/Scripts/ruff) not found; falling back to bundled executable
@FrancescElies FrancescElies changed the title ruff fromEnvironment not found under windows ruff fromEnvironment (vscode extension) not found under windows Jan 2, 2023
@charliermarsh charliermarsh self-requested a review January 3, 2023 12:22
@FrancescElies
Copy link
Contributor Author

platform is more redeable thanks!

@charliermarsh
Copy link
Member

Thank you! I wasn't really sure, I had to do some Googling, it felt a bit more familiar to me than nt.

@charliermarsh
Copy link
Member

I'm confused why this didn't fail on CI before. I need to look into that.

@charliermarsh charliermarsh merged commit d4b5c12 into astral-sh:main Jan 3, 2023
@FrancescElies
Copy link
Contributor Author

Maybe CI is using the bundle? This failed when switching to fromEnvironment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants