Avoid false-positives for break in with (#3032)

astral-sh · Feb 19, 2023 · 0f0e7a5 · 0f0e7a5
1 parent b75663b
commit 0f0e7a5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/crates/ruff/resources/test/fixtures/pylint/useless_else_on_loop.py b/crates/ruff/resources/test/fixtures/pylint/useless_else_on_loop.py
@@ -113,3 +113,14 @@ def test_break_in_if_orelse():
     else:
         return True
     return False
+
+
+def test_break_in_with():
+    """no false positive for break in with"""
+    for name in ["demo"]:
+        with open(__file__) as f:
+            if name in f.read():
+                break
+    else:
+        return True
+    return False
diff --git a/crates/ruff/src/rules/pylint/rules/useless_else_on_loop.rs b/crates/ruff/src/rules/pylint/rules/useless_else_on_loop.rs
@@ -22,6 +22,7 @@ impl Violation for UselessElseOnLoop {
 fn loop_exits_early(body: &[Stmt]) -> bool {
     body.iter().any(|stmt| match &stmt.node {
         StmtKind::If { body, orelse, .. } => loop_exits_early(body) || loop_exits_early(orelse),
+        StmtKind::With { body, .. } | StmtKind::AsyncWith { body, .. } => loop_exits_early(body),
         StmtKind::Try {
             body,
             handlers,