Skip to content

Commit

Permalink
misc: use correct names for visitor arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
dhruvmanila committed Nov 23, 2023
1 parent 8193ff9 commit 1e72af2
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 4 deletions.
12 changes: 10 additions & 2 deletions crates/ruff_python_ast/src/visitor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -776,7 +776,15 @@ pub fn walk_cmp_op<'a, V: Visitor<'a> + ?Sized>(visitor: &V, cmp_op: &'a CmpOp)
pub fn walk_alias<'a, V: Visitor<'a> + ?Sized>(visitor: &V, alias: &'a Alias) {}

#[allow(unused_variables)]
pub fn walk_string_literal<'a, V: Visitor<'a> + ?Sized>(visitor: &V, alias: &'a StringLiteral) {}
pub fn walk_string_literal<'a, V: Visitor<'a> + ?Sized>(
visitor: &V,
string_literal: &'a StringLiteral,
) {
}

#[allow(unused_variables)]
pub fn walk_bytes_literal<'a, V: Visitor<'a> + ?Sized>(visitor: &V, alias: &'a BytesLiteral) {}
pub fn walk_bytes_literal<'a, V: Visitor<'a> + ?Sized>(
visitor: &V,
bytes_literal: &'a BytesLiteral,
) {
}
8 changes: 6 additions & 2 deletions crates/ruff_python_ast/src/visitor/transformer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,11 @@ pub fn walk_cmp_op<V: Transformer + ?Sized>(visitor: &V, cmp_op: &mut CmpOp) {}
pub fn walk_alias<V: Transformer + ?Sized>(visitor: &V, alias: &mut Alias) {}

#[allow(unused_variables)]
pub fn walk_string_literal<V: Transformer + ?Sized>(visitor: &V, alias: &mut StringLiteral) {}
pub fn walk_string_literal<V: Transformer + ?Sized>(
visitor: &V,
string_literal: &mut StringLiteral,
) {
}

#[allow(unused_variables)]
pub fn walk_bytes_literal<V: Transformer + ?Sized>(visitor: &V, alias: &mut BytesLiteral) {}
pub fn walk_bytes_literal<V: Transformer + ?Sized>(visitor: &V, bytes_literal: &mut BytesLiteral) {}

0 comments on commit 1e72af2

Please sign in to comment.