Ignore explicit overrides

astral-sh · Jul 25, 2023 · ad4c015 · ad4c015
1 parent 11dd457
commit ad4c015
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 9 deletions.
diff --git a/crates/ruff/resources/test/fixtures/flake8_builtins/A003.py b/crates/ruff/resources/test/fixtures/flake8_builtins/A003.py
@@ -45,14 +45,9 @@ def str(self) -> None:
 
 
 class MyClass:
-    ImportError = 4
-    id: int
-    dir = "/"
-
-    def __init__(self):
-        self.float = 5  # is fine
-        self.id = 10
-        self.dir = "."
-
+    @override
     def str(self):
         pass
+
+    def int(self):
+        pass
diff --git a/...rc/rules/flake8_builtins/snapshots/ruff__rules__flake8_builtins__tests__A003_A003.py.snap b/...rc/rules/flake8_builtins/snapshots/ruff__rules__flake8_builtins__tests__A003_A003.py.snap
@@ -56,4 +56,13 @@ A003.py:40:9: A003 Class attribute `str` is shadowing a Python builtin
 41 |         ...
    |
 
+A003.py:52:9: A003 Class attribute `int` is shadowing a Python builtin
+   |
+50 |         pass
+51 | 
+52 |     def int(self):
+   |         ^^^ A003
+53 |         pass
+   |
+
 
diff --git a/...tins/snapshots/ruff__rules__flake8_builtins__tests__A003_A003.py_builtins_ignorelist.snap b/...tins/snapshots/ruff__rules__flake8_builtins__tests__A003_A003.py_builtins_ignorelist.snap
@@ -37,4 +37,13 @@ A003.py:40:9: A003 Class attribute `str` is shadowing a Python builtin
 41 |         ...
    |
 
+A003.py:52:9: A003 Class attribute `int` is shadowing a Python builtin
+   |
+50 |         pass
+51 | 
+52 |     def int(self):
+   |         ^^^ A003
+53 |         pass
+   |
+