Skip to content

Commit

Permalink
Fix default for max-positional-args (#9838)
Browse files Browse the repository at this point in the history
<!--
Thank you for contributing to Ruff! To help us out with reviewing,
please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title?
- Does this pull request include references to any relevant issues?
-->

## Summary
`max-positional-args` defaults to `max-args` if it's not specified and
the default to `max-args` is 5, so saying that the default is 3 is
definitely wrong. Ideally, we wouldn't specify a default at all for this
config option, but I don't think that's possible?

<!-- What's the purpose of the change? What does it do, and why? -->

## Test Plan

<!-- How was it tested? -->
Not sure.
  • Loading branch information
tmke8 committed Feb 5, 2024
1 parent 7390232 commit e708c08
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/ruff_workspace/src/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2756,7 +2756,7 @@ pub struct PylintOptions {
///
/// If not specified, defaults to the value of `max-args`.
#[option(
default = r"3",
default = r"5", // Needs to be in sync with default of `max-args`.
value_type = "int",
example = r"max-positional-args = 3"
)]
Expand Down

0 comments on commit e708c08

Please sign in to comment.