Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fails on 32 bits archs #10470

Closed
raspbeguy opened this issue Mar 19, 2024 · 3 comments · Fixed by #10478
Closed

Tests fails on 32 bits archs #10470

raspbeguy opened this issue Mar 19, 2024 · 3 comments · Fixed by #10478
Assignees
@charliermarsh
Labels
bug Something isn't working testing Related to testing Ruff itself

Comments

@raspbeguy
Copy link

Hello, this issue is following #10359.

Now that display_default_settings is fixed, some other tests are failing specifically on 32 bits archs:

failures:
    rules::flake8_logging::tests::rules::rule_undocumentedwarn_path_new_log009_py_expects
    rules::pyupgrade::tests::datetime_utc_alias_py311
    rules::refurb::tests::rules::rule_redundantlogbase_path_new_furb163_py_expects
    rules::ruff::tests::implicit_optional_py39::path_new_ruf013_0_py_expects
    rules::tryceratops::tests::rules::rule_errorinsteadofexception_path_new_try400_py_expects

I attach the complete error log.
ruff_build.log

Thanks.
@dhruvmanila dhruvmanila added bug Something isn't working testing Related to testing Ruff itself labels Mar 19, 2024
@charliermarsh charliermarsh self-assigned this Mar 19, 2024
@charliermarsh
Copy link
Member

I'll take a look... my guess is there's some non-determinism?

@charliermarsh charliermarsh mentioned this issue Mar 19, 2024
Merged
charliermarsh added a commit that referenced this issue Mar 19, 2024
@charliermarsh
Avoid failures due to non-deterministic binding ordering (#10478)
bc9b457 
## Summary

We're seeing failures in #10470
because `resolve_qualified_import_name` isn't guaranteed to return a
specific import if a symbol is accessible in two ways (e.g., you have
both `import logging` and `from logging import error` in scope, and you
want `logging.error`). This PR breaks up the failing tests such that the
imports aren't in the same scope.

Closes #10470.

## Test Plan

I added a `bindings.reverse()` to `resolve_qualified_import_name` to
ensure that the tests pass regardless of the binding order.
@charliermarsh
Copy link
Member

Should be fixed now.

@raspbeguy
Copy link
Author

I confirm that it's working now. Thanks.

algitbot pushed a commit to alpinelinux/aports that referenced this issue Mar 22, 2024
@WhyNotHugo
testing/ruff: enable on other architectures
9715dab 
Fixes: https://gitlab.alpinelinux.org/alpine/aports/-/issues/15642
See: astral-sh/ruff#10359
See: astral-sh/ruff#10470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working testing Related to testing Ruff itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid failures due to non-deterministic binding ordering astral-sh/ruff
3 participants
@charliermarsh @raspbeguy @dhruvmanila