misleading E721 Do not compare types, use isinstance() for bool

[Borda]

just crossed this case where for type(component_wise) is bool ruff suggest generic isinstance(component_wise, bool) which is not the same as this comparison takes int as bool:

>>> isinstance(5, bool)
True
>>> type(5) is bool
False

see why this si happening in https://stackoverflow.com/a/37888668/4521646

[mscheifer]

I think your example is backwards. bools are ints but not the other way around.

>>> isinstance(5, bool)
False
>>> isinstance(True, int)
True

[dhruvmanila]

Yeah, I think the behavior is correct?

>>> isinstance(5, bool)
False
>>> type(5) is bool
False

As per the linked stackoverflow question, I think the problem would be when you compare against an int where the behavior is different:

>>> isinstance(5, int)
True
>>> isinstance(True, int)
True
>>> type(5) is int
True
>>> type(True) is int
False

Also, this is already resolved in --preview, refer #7905. It should available generally in the next minor bump.

[charliermarsh]

Closing based on @dhruvmanila's analysis.