Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: switch flake8 to Ruff #2323

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Apr 12, 2024

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #2195

Summary

Switch lint flake8 to Ruff with the same basic checks.
As follow-up, we could also merge Black + pyupgrade + isort (after merging this one I'll prepare separate PRs for each of them)

Other Information

Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution, some minor comments (mostly about fixing E721).

darts/ad/anomaly_model/filtering_am.py Show resolved Hide resolved
requirements/dev.txt Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
darts/ad/scorers/scorers.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (db570e6) to head (f91dfcf).

❗ Current head f91dfcf differs from pull request most recent head 8811614. Consider uploading reports for the commit 8811614 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2323      +/-   ##
==========================================
- Coverage   94.02%   94.01%   -0.02%     
==========================================
  Files         138      138              
  Lines       14201    14187      -14     
==========================================
- Hits        13353    13338      -15     
- Misses        848      849       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Borda
Copy link
Contributor Author

Borda commented Apr 16, 2024

@madtoinou seem all is finally passing

Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @Borda for initiating the transition to ruff!

I'll add an entry in the backlog, see if we can find a more elegant solution to these "type checks" to get ride of the #noqa in the long run.

@dennisbader dennisbader merged commit 2de4fcc into unit8co:master Apr 17, 2024
7 of 9 checks passed
@Borda Borda deleted the lint/ruff branch April 17, 2024 19:15
@dennisbader dennisbader mentioned this pull request Apr 30, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch to Ruff instead of flake8
3 participants