Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIE790: leave comments? #2231

Closed
spaceone opened this issue Jan 26, 2023 · 0 comments · Fixed by #2235
Closed

PIE790: leave comments? #2231

spaceone opened this issue Jan 26, 2023 · 0 comments · Fixed by #2235

Comments

@spaceone
Copy link
Contributor

spaceone commented Jan 26, 2023 •
edited

PIE790 removed the pass statement and the comment.

 def handler_add(dn: str, new: Dict[str, List[bytes]]) -> None:
        """Handle creation of object."""
-       pass  # replace this

The comment is more like an instruction for implementors. Well, this has not high quality.
But maybe it would be good to just leave the comment??
@charliermarsh charliermarsh mentioned this issue Jan 26, 2023
Merged
charliermarsh added a commit that referenced this issue Jan 26, 2023
@charliermarsh
Avoid removing trailing comments on pass statements (#2235)
a6ec2eb 
This isn't super consistent with some other rules, but... if you have a lone body, with a `pass`, followed by a comment, it's probably surprising if it gets removed. Let's retain the comment.

Closes #2231.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid removing trailing comments on pass statements astral-sh/ruff
1 participant
@spaceone