Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flake8-class-attributes-order #2425

Open
2 tasks
edgarrmondragon opened this issue Jan 31, 2023 · 5 comments
Open
2 tasks

Support flake8-class-attributes-order #2425

edgarrmondragon opened this issue Jan 31, 2023 · 5 comments
Labels
needs-decision Awaiting a decision from a maintainer plugin Implementing a known but unsupported plugin

Comments

@edgarrmondragon
Copy link
Contributor

Hello,
Is there a plan to support this flake8 extension?
https://pypi.org/project/flake8-class-attributes-order/

Originally posted by @WorkHardes in #106 (comment)

  • CCE001: Wrong class attributes order (XXX should be after YYY)
  • CCE002: Class level expression detected
@edgarrmondragon edgarrmondragon changed the title Hello, Support flake8-class-attributes-order Jan 31, 2023
@charliermarsh charliermarsh added the plugin Implementing a known but unsupported plugin label Jan 31, 2023
@charliermarsh charliermarsh added the needs-decision Awaiting a decision from a maintainer label Jul 10, 2023
@sigma67
Copy link

sigma67 commented Nov 6, 2023

Has there been a decision to include this yet? Seems quite a few people would use it

@lexygon
Copy link

lexygon commented Jan 30, 2024

Any decisions on this? It would be an awesome addition

@zanieb
Copy link
Member

zanieb commented Mar 11, 2024

This one's hard to implement and can generally be unsafe. We don't have plans to implement it soon. Now that we unsafe fix support it might be more reasonable.

cc @AlexWaygood this kind of thing may be worth considering in categorization.

Related #3946

@sigma67
Copy link

sigma67 commented Mar 11, 2024

I think auto-fixing isn't even the feature request here - although certainly a nice bonus.

Just having the detection capability would be great.

Does your argument only apply to the fixing part or do you also consider the detection hard to implement?

@yury-fedotov
Copy link
Contributor

+1 to this, would be awesome to have it! I think almost any Python project defines many classes, hence having a consistent order of attributes is critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-decision Awaiting a decision from a maintainer plugin Implementing a known but unsupported plugin
Projects
None yet
Development

No branches or pull requests

6 participants