Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid enforcing EXE001 and EXE002 checks on Windows #3110

Closed
charliermarsh opened this issue Feb 22, 2023 · 2 comments · Fixed by #3111
Closed

Avoid enforcing EXE001 and EXE002 checks on Windows #3110

charliermarsh opened this issue Feb 22, 2023 · 2 comments · Fixed by #3111
Labels
bug Something isn't working

Comments

@charliermarsh
Copy link
Member

charliermarsh commented Feb 22, 2023 •
edited 

I noticed this because pre-commit running on `windows-latest` [Azure DevOps](https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml#software) agents, failed, where the Linux jobs pass.

I just `pip install ruff` there ¯\\_(ツ)_/¯

Originally posted by @basnijholt in #2118 (comment)
@charliermarsh charliermarsh added the bug Something isn't working label Feb 22, 2023
@charliermarsh charliermarsh mentioned this issue Feb 22, 2023
Merged
@basnijholt
Copy link

Thanks for opening this and thanks for the amazing package!

For reference, flake8-executable also ignore this on Windows https://github.com/xuhdev/flake8-executable/blob/2b6c3fec0f7ccb175fe34f2a613b762af2a35536/flake8_executable/__init__.py#L67-L86

@charliermarsh
Copy link
Member Author

Oh nice! That's good to know too! And thank you for the kind words :)

@bersbersbers bersbersbers mentioned this issue Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip EXE001 and EXE002 rules on Windows astral-sh/ruff
2 participants
@charliermarsh @basnijholt