Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EXE001 and EXE002 from flake8-executable #2118

Merged
merged 6 commits into from
Jan 24, 2023
Merged

Implement EXE001 and EXE002 from flake8-executable #2118

merged 6 commits into from
Jan 24, 2023

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon
Copy link
Contributor Author

I think the clippy check for wasm is failing because Metadata.mode() is only available on Unix

@charliermarsh charliermarsh merged commit f5f0ed2 into astral-sh:main Jan 24, 2023
@basnijholt
Copy link

These shouldn't be executed on Windows.

@charliermarsh
Copy link
Member

How do the Unix extensions even compile on Windows?

@basnijholt
Copy link

basnijholt commented Feb 22, 2023 •
edited
Loading

I noticed this because pre-commit running on windows-latest Azure DevOps agents, failed, where the Linux jobs pass.

I just pip install ruff there ¯\(ツ)/¯

@charliermarsh charliermarsh mentioned this pull request Feb 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edgarrmondragon @basnijholt @charliermarsh