Implement `perflint`

[93578237]

https://github.com/tonybaloney/perflint - Python Linter for performance anti patterns.

• PERF101: Unnecessary list() on already iterable type (unnecessary-list-cast)
• PERF102: Incorrect iterator method for dictionary (incorrect-dictionary-iterator)
• PERF201: Loop invariant statement (loop-invariant-statement)
• PERF202: Global name usage in a loop (loop-global-usage)
• PERF203: Try..except blocks have a significant overhead. Avoid using them inside a loop (loop-try-except-usage)
• PERF204: Looped slicing of bytes objects is inefficient. Use a memoryview() instead (memoryview-over-bytes)
• PERF205: Importing the "%s" name directly is more efficient in this loop. (dotted-import-in-loop)
• PERF301: Use tuple instead of list for a non-mutated sequence. (use-tuple-over-list)
• PERF401: Use a list comprehension instead of a for-loop (use-list-comprehension)
• PERF402: Use a list copy instead of a for-loop (use-list-copy)
• PERF403: Use a dictionary comprehension instead of a for-loop (use-dict-comprehension)

[93578237]

Also rules from https://github.com/tonybaloney/anti-patterns
like tonybaloney/anti-patterns#4 and tonybaloney/anti-patterns#5

[qdegraaf]

If that's a separate plugin it's best to make a different issue for that. As for perflint, I will wait until the first PR is merged before looking at further rules.

[qdegraaf]

Rules checklist:

EDIT: Added to Issue body

[evanrittenhouse]

@qdegraaf I can pick up some of these - are there any that you're particularly interested in? Don't want to overstep

[charliermarsh]

Thanks @qdegraaf - I went ahead and added that to the issue body :)

[qdegraaf]

@qdegraaf I can pick up some of these - are there any that you're particularly interested in? Don't want to overstep

Awesome! I've got an almost complete PERF101. Otherwise haven't picked up anything yet. I'll open a draft PR for PERF101 and otherwise take your pick! Feel free to ping me on the Discord if you want to collaborate or check availability.

[evanrittenhouse]

I can grab PERF203 and PERF301 to start.

[qdegraaf]

I'll start looking at 401 and 402

EDIT: Picked up 403 in a separate PR as well. I can leave the 2X and 3X to you if you like @evanrittenhouse

[evanrittenhouse]

@qdegraaf You can grab 3X as well! I'll do 2X, if that works for you?

[93578237]

If that's a separate plugin it's best to make a different issue for that.

Rules from perflint are derived from tonybaloney/anti-patterns.
These rules ( tonybaloney/anti-patterns#4 and tonybaloney/anti-patterns#5) are not yet implemented in perflint (tonybaloney/perflint#31)

So these 2 rules (join with generator and regex with IGNORECASE) should be part of perflint or RUF rules?

[qdegraaf]

If that's a separate plugin it's best to make a different issue for that.

Rules from perflint are derived from tonybaloney/anti-patterns. These rules ( tonybaloney/anti-patterns#4 and tonybaloney/anti-patterns#5) are not yet implemented in perflint (tonybaloney/perflint#31)

So these 2 rules (join with generator and regex with IGNORECASE) should be part of perflint or RUF rules?

@charliermarsh what's the protocol for this. I think it makes functional sense to add it to perflint but not sure if Ruff is ok with expanding upon upstream plugin scope for direct ports.

@qdegraaf You can grab 3X as well! I'll do 2X, if that works for you?

Cool, works for me! If I get round to them at some point in the near future I'll make sure to announce it here. Feel free to change your mind in the meantime if you find time before me.