Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules PERF102 cause autofix error #7097

Closed
qarmin opened this issue Sep 3, 2023 · 1 comment · Fixed by #7554
Closed

Rules PERF102 cause autofix error #7097

qarmin opened this issue Sep 3, 2023 · 1 comment · Fixed by #7554
Assignees
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.

Comments

@qarmin
Copy link

qarmin commented Sep 3, 2023

Ruff 0.0.287 (latest changes from main branch)

ruff  *.py --select PERF102 --no-cache --fix

file content(at least simple cpython script shows that this is valid python file):

def _create_context(name_to_value):
	for(B,D)in A.items():
		if(C:=name_to_value.get(B.name)):A.run(B.set,C)

error

/home/rafal/test/tmp_folder/378862.py:2:13: PERF102 When using only the keys of a dict use the `keys()` method
Found 1 error.

error: Autofix introduced a syntax error. Reverting all changes.

This indicates a bug in `ruff`. If you could open an issue at:

    https://github.com/astral-sh/ruff/issues/new?title=%5BAutofix%20error%5D

...quoting the contents of `/home/rafal/test/tmp_folder/378862.py`, the rule codes PERF102, along with the `pyproject.toml` settings and executed command, we'd be very appreciative!


python_compressed.zip

@zanieb zanieb added the fuzzer Surfaced via fuzzing. label Sep 3, 2023
@charliermarsh charliermarsh added the bug Something isn't working label Sep 3, 2023
@charliermarsh
Copy link
Member

We're fixing to:

def _create_context(name_to_value):
    forBin A.keys():
        if(C:=name_to_value.get(B.name)):A.run(B.set,C)

We need to add space after the for and before the in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants