Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule RUF013 cause autofix error #7199

Closed
qarmin opened this issue Sep 6, 2023 · 0 comments · Fixed by #7553
Closed

Rule RUF013 cause autofix error #7199

qarmin opened this issue Sep 6, 2023 · 0 comments · Fixed by #7553
Assignees
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.

Comments

@qarmin
Copy link

qarmin commented Sep 6, 2023

Ruff 0.0.287 (latest changes from main branch)

ruff  *.py --select RUF013 --no-cache --fix

file content(at least simple cpython script shows that this is valid python file):

from Tea.model import TeaModel\

class Config(TeaModel):
    def __init__(
        read_timeout: int = None,
    ):
        self.access_key_id = access_keyid

error

/home/rafal/test/tmp_folder/298_IDX_0_RAND_79953379162912133788556.py:5:23: RUF013 PEP 484 prohibits implicit `Optional`
Found 1 error.

error: Autofix introduced a syntax error. Reverting all changes.

This indicates a bug in `ruff`. If you could open an issue at:

    https://github.com/astral-sh/ruff/issues/new?title=%5BAutofix%20error%5D

...quoting the contents of `/home/rafal/test/tmp_folder/298_IDX_0_RAND_79953379162912133788556.py`, the rule codes RUF013, along with the `pyproject.toml` settings and executed command, we'd be very appreciative!

@MichaReiser MichaReiser added bug Something isn't working fuzzer Surfaced via fuzzing. labels Sep 6, 2023
@charliermarsh charliermarsh self-assigned this Sep 20, 2023
charliermarsh added a commit that referenced this issue Sep 20, 2023
## Summary

This is extremely rare in practice, but common in the fuzzer issues so
worth fixing quickly.

Closes #7199.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants