Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: Prevent duplicate warnings for repeated selections #7367

Open
zanieb opened this issue Sep 13, 2023 · 0 comments
Open

Preview: Prevent duplicate warnings for repeated selections #7367

zanieb opened this issue Sep 13, 2023 · 0 comments
Labels
preview Related to preview mode features

Comments

@zanieb
Copy link
Member

zanieb commented Sep 13, 2023

When we throw warnings for deprecated selections of nursery rules, we don't check if we have warned before.

Because this doesn't use warn_user_once_by_id, the warnings will probably show up multiple times if we run this configuration resolution multiple times (which we might in a given invocation -- I can't remember exactly). Is it possible to use warn_user_once_by_id?

Originally posted by @charliermarsh in #7210 (comment)

@zanieb zanieb added the preview Related to preview mode features label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Related to preview mode features
Projects
None yet
Development

No branches or pull requests

1 participant