Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview rule stabilizations for v0.2.0 #7993

Closed
zanieb opened this issue Oct 16, 2023 · 7 comments · Fixed by #9680
Closed

Preview rule stabilizations for v0.2.0 #7993

zanieb opened this issue Oct 16, 2023 · 7 comments · Fixed by #9680
Milestone

Comments

@zanieb
Copy link
Member

zanieb commented Oct 16, 2023

New rules are now added in preview. This issue serves as a central discussion for rules that should be promoted from preview to stable in the next breaking version of Ruff.

@zanieb zanieb added this to the v0.2.0 milestone Oct 16, 2023
@zanieb zanieb changed the title Rule stabilizations for v0.2.0 Preview rule stabilizations for v0.2.0 Oct 17, 2023
@NeilGirdhar
Copy link

NeilGirdhar commented Oct 17, 2023

I tried out the previewed rules, and I got useful hits from:

  • E114 Indentation is not a multiple of 4 (comment)
  • E116 Unexpected indentation (comment)
  • E203 [*] Whitespace before ','
  • E241 Multiple spaces after comma
  • E271 Multiple spaces after keyword
  • FURB113 [*] Use args.extend(...) instead of repeatedly calling args.append()

Also, see this comment on PLR6301

@dhruvmanila
Copy link
Member

Do we want to add all the existing rules in preview here as a checklist?

@charliermarsh
Copy link
Member

I'd love to drop some duplicate rules in the next minor, e.g., #8830.

@charliermarsh
Copy link
Member

I think we should elevate the C rule fixes to "safe". I believe they're unsafe right now because we risk dropping comments, but that's not really the intent of fix safety.

@charliermarsh
Copy link
Member

We should also elevate UP006 and UP007 to safe in some cases.

@zanieb
Copy link
Member Author

zanieb commented Nov 30, 2023

I'd love to drop some duplicate rules in the next minor, e.g., #8830.

Can we remove rules in preview? If not, maybe we should add a "Deprecated" rule group that acts as removed when preview mode is enabled.

@charliermarsh
Copy link
Member

I think we should also deprecate PLR1706 (#9007).

@charliermarsh charliermarsh mentioned this issue Jan 11, 2024
13 tasks
@zanieb zanieb mentioned this issue Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants