Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive RUF013 PEP 484 prohibits implicit Optional #9334

Closed
randolf-scholz opened this issue Dec 31, 2023 · 1 comment · Fixed by #9335
Closed

False positive RUF013 PEP 484 prohibits implicit Optional #9334

randolf-scholz opened this issue Dec 31, 2023 · 1 comment · Fixed by #9335
Assignees
@charliermarsh
Labels
bug Something isn't working

Comments

@randolf-scholz
Copy link

The bug occurs if Optional is imported from typing_extensions instead of typing.

from typing_extensions import Optional

def foo(x: Optional[int] = None):
     pass

https://play.ruff.rs/dda2f645-171a-4666-93c6-d686c3f7edfa
@charliermarsh charliermarsh added the bug Something isn't working label Dec 31, 2023
@charliermarsh charliermarsh self-assigned this Dec 31, 2023
@charliermarsh charliermarsh mentioned this issue Dec 31, 2023
Merged
@charliermarsh
Copy link
Member

Fixed in #9335, thanks.

charliermarsh added a commit that referenced this issue Dec 31, 2023
@charliermarsh
Treat all typing_extensions members as typing aliases (#9335)
195f7c0 
## Summary

Historically, we encoded this list by extracting the `__all__`. I went
to update it, but... is there really any value in it? Seems easier to
just treat `typing_extensions` as an alias for `typing`.

Closes #9334.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat all typing_extensions members as typing aliases astral-sh/ruff
2 participants
@charliermarsh @randolf-scholz