Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR title guidelines to CONTRIBUTING.md #9470

Closed
trag1c opened this issue Jan 11, 2024 · 2 comments · Fixed by #10665
Closed

Add PR title guidelines to CONTRIBUTING.md #9470

trag1c opened this issue Jan 11, 2024 · 2 comments · Fixed by #10665
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@trag1c
Copy link
Contributor

trag1c commented Jan 11, 2024

I had difficulty deciding on a suitable name when opening a pull request recently. I couldn't find any guidance on naming PRs in CONTRIBUTING.md despite seeing some of them be renamed before merging (e.g., #9166, #9174, #8995, #8036).

I think adding some naming guidelines could be helpful for both contributors and maintainers. Just to share my experience, I spent around 10 minutes going through recently merged PRs trying to perfect the name of mine. 😄

@Tade77
Copy link

Tade77 commented Jan 11, 2024

Hello @trag1c i'm frontend developer, i would like tto work on this issue

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Jan 13, 2024
@charliermarsh
Copy link
Member

Hah, yeah, this would be great. I end up doing the names either before merging or when creating the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants