Default copyright pattern doesn't allow commas

[dopplershift]

As of ruff 0.1.11, the default notice-rgx does not allow for headers that have commas, like:

Copyright (c) 2018, 2019 Developers

Part of the docs do say that (?i)Copyright\s+(\(C\)\s+)?\d{4}([-,]\d{4})* is the default pattern (which works), but there's also (?i)Copyright\s+(\(C\)\s+)?\d{4}(-\d{4})* mentioned in a separate sentence in the docs and matches what's in COPYRIGHT (and reflects actual behavior). Any reason commas shouldn't be accepted?

[charliermarsh]

I think it might be an oversight. We should probably allow commas there.

[dopplershift]

PR submitted in #9498.

[charliermarsh]

I believe this is allowed, at least in my testing: https://play.ruff.rs/b1dc1b2a-afec-48e6-82b5-ce7eb68fbf33. Closing for now but happy to revisit!

[dopplershift]

@charliermarsh I think this and #9498 were closed in error, my local testing still shows a need to manually set notice_rgx in order to get this behavior accepting commas.

I think the reason your testing didn't show a problem is because you have to set tool.ruff.lint.flake8-copyright.author to "Developers" in order to enable the check I believe.

I can't figure out how to share it, but I verified this by setting the author properly on your link above.

[dopplershift]

Ping @charliermarsh

[charliermarsh]

Ack, will take another look!

[dopplershift]

Ping since there's a PR to fix sitting in #9498.

[charliermarsh]

Thanks, I think you're right, that does it. I'll get it merged now, but need to add tests.

[dopplershift]

Thanks!