New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Admonition in dark mode #9501

Closed

pabepadu opened this issue Jan 13, 2024 · 0 comments · Fixed by #9502

Contributor

pabepadu commented Jan 13, 2024 •

edited

The admonition in dark mode are in actually same as in light mode here: https://docs.astral.sh/ruff/formatter/#ruff-format

I propose to move admonition in real dark mode as shown below

Before the PR [docs] - Fix admonition hyperlink colouring #9385
Current version
Proposal

pabepadu mentioned this issue

fix(docs): admonition in dark mode #9502

Merged

charliermarsh closed this as completed in #9502

charliermarsh pushed a commit that referenced this issue


          fix(docs): admonition in dark mode (#9502)

ef2798f

## Summary

The admonition in dark mode are in actually same as in light mode here:
https://docs.astral.sh/ruff/formatter/#ruff-format

I propose to move admonition in real dark mode as shown below:
- Before the PR #9385

![image](https://github.com/astral-sh/ruff/assets/45884742/abb7e0db-bf12-49cd-9f9b-e353accd571f)
- Current version

![image](https://github.com/astral-sh/ruff/assets/45884742/da8ab46d-dc87-412e-be2b-ac937cd87666)
- Proposal

![image](https://github.com/astral-sh/ruff/assets/45884742/7279cb02-e6af-4320-9dee-486fbfddcbc8)

Close #9501

## Test Plan

Documentation was regenerated via mkdocs and the supplied requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment