SIM103 suggestion negates the original conditional expression

[chunyang]

Consider the following Python code:

def opposite(a: bool) -> bool:
    if a:
        return False
    else:
        return True

When I run ruff on the code with the SIM checks selected, the suggested replacement returns the opposite of the expected value.

% ruff check --isolated --select SIM --show-source sim103.py 
sim103.py:2:5: SIM103 Return the condition `a` directly
  |
1 |   def opposite(a: bool) -> bool:
2 |       if a:
  |  _____^
3 | |         return False
4 | |     else:
5 | |         return True
  | |___________________^ SIM103
  |
  = help: Replace with `return a`

If I switch False and True in the code, the suggested replacement remains the same, but is then correct.

% ruff --version
ruff 0.1.14

Playground link: https://play.ruff.rs/7d91158b-0d65-4cc1-95f3-435136f0d1e9

[chunyang]

Seems related to #2037 but IIUC that only disabled the autofix, but didn't fix the suggestion.

[charliermarsh]

Ah thanks -- that does look like a bug.

[charliermarsh]

I'll re-enable the fix, and insert the correct code and suggestion.

[charliermarsh]

Fixed in the next release, thanks!

[chunyang]

Thanks for the quick fix!