Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject corpus which produces empty range for LALRPOP parser #10876

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

dhruvmanila
Copy link
Member

Summary

This PR updates the ruff_new_parser_equiv fuzzer target to reject the corpus which produces an empty range for the AST from LALRPOP. If there are no nodes, then LALRPOP produces an empty range while the new parser uses the correct range of the source itself.

@dhruvmanila dhruvmanila added parser Related to the parser fuzzer Surfaced via fuzzing. labels Apr 11, 2024
Copy link

codspeed-hq bot commented Apr 11, 2024

CodSpeed Performance Report

Merging #10876 will degrade performances by 5.27%

Comparing dhruv/fuzz-reject-empty-range (b6a8c19) with dhruv/parser (301ba35)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark dhruv/parser dhruv/fuzz-reject-empty-range Change
parser[large/dataset.py] 28.9 ms 26.7 ms +8.22%
parser[pydantic/types.py] 11.8 ms 10.9 ms +8.77%
parser[unicode/pypinyin.py] 1.6 ms 1.7 ms -5.27%

@dhruvmanila dhruvmanila changed the title Reject corpus which produces empty range Reject corpus which produces empty range for LALRPOP parser Apr 11, 2024
@dhruvmanila dhruvmanila merged commit b069358 into dhruv/parser Apr 11, 2024
16 of 17 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/fuzz-reject-empty-range branch April 11, 2024 12:28
dhruvmanila added a commit that referenced this pull request Apr 11, 2024
## Summary

This PR updates the `ruff_new_parser_equiv` fuzzer target to reject the
corpus which produces an empty range for the AST from LALRPOP. If there
are no nodes, then LALRPOP produces an empty range while the new parser
uses the correct range of the source itself.
dhruvmanila added a commit that referenced this pull request Apr 15, 2024
## Summary

This PR updates the `ruff_new_parser_equiv` fuzzer target to reject the
corpus which produces an empty range for the AST from LALRPOP. If there
are no nodes, then LALRPOP produces an empty range while the new parser
uses the correct range of the source itself.
dhruvmanila added a commit that referenced this pull request Apr 16, 2024
## Summary

This PR updates the `ruff_new_parser_equiv` fuzzer target to reject the
corpus which produces an empty range for the AST from LALRPOP. If there
are no nodes, then LALRPOP produces an empty range while the new parser
uses the correct range of the source itself.
dhruvmanila added a commit that referenced this pull request Apr 16, 2024
## Summary

This PR updates the `ruff_new_parser_equiv` fuzzer target to reject the
corpus which produces an empty range for the AST from LALRPOP. If there
are no nodes, then LALRPOP produces an empty range while the new parser
uses the correct range of the source itself.
dhruvmanila added a commit that referenced this pull request Apr 17, 2024
## Summary

This PR updates the `ruff_new_parser_equiv` fuzzer target to reject the
corpus which produces an empty range for the AST from LALRPOP. If there
are no nodes, then LALRPOP produces an empty range while the new parser
uses the correct range of the source itself.
dhruvmanila added a commit that referenced this pull request Apr 18, 2024
## Summary

This PR updates the `ruff_new_parser_equiv` fuzzer target to reject the
corpus which produces an empty range for the AST from LALRPOP. If there
are no nodes, then LALRPOP produces an empty range while the new parser
uses the correct range of the source itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzzer Surfaced via fuzzing. parser Related to the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant