Add if as sequence pattern list terminator
#10996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
force-pushed
the
dhruv/remove-del-named-expr
branch
from
d6c4c3a
to
d6b072d
Compare
dhruvmanila
force-pushed
the
dhruv/match-seq-pattern
branch
from
07e850c
to
c836049
Compare
CodSpeed Performance ReportMerging #10996 will not alter performanceComparing Summary
|
MichaReiser
approved these changes
Apr 17, 2024
dhruvmanila
force-pushed
the
dhruv/remove-del-named-expr
branch
from
d6b072d
to
8020b40
Compare
This fixes a bug for code like:
```python
match subject:
case a, b if expr: ...
```
Previously, the `:` was the only terminator token so the list parsing
wouldn't stop after `b`. The `if` token has been added to the terminator
list to fix this.
dhruvmanila
force-pushed
the
dhruv/match-seq-pattern
branch
from
c836049
to
a0799ca
Compare
|
dhruvmanila
added a commit
that referenced
this pull request
Apr 18, 2024
## Summary
This fixes a bug for code like:
```python
match subject:
case a, b if expr: ...
```
Previously, the `:` was the only terminator token so the list parsing
wouldn't stop after `b`. The `if` token has been added to the terminator
list to fix this.
## Test Plan
Add test cases and verified the snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug for code like:
Previously, the
:was the only terminator token so the list parsing wouldn't stop afterb. Theiftoken has been added to the terminator list to fix this.Test Plan
Add test cases and verified the snapshots.