Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pyflakes] Update docs to describe WAI behavior (F541) #11362

Merged
merged 2 commits into from
May 10, 2024

Conversation

dougthor42
Copy link
Contributor

Addresses this comment:
#11357 (comment)

Summary

The docs for F541 did not mention some surprising, but WAI, behavior regarding implicit string concatenation. Update the docs to describe the behavior.

Here's how things rendered for me locally:

image

Test Plan

N/A

Copy link
Contributor

github-actions bot commented May 10, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@dougthor42
Copy link
Contributor Author

For the mkdocs formatting failure:

The multi-line string makes things more obvious IMO. How should I disable the autoformatter for this case? Or is the one-line implicit string concatenation easy enough to read?

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label May 10, 2024
@charliermarsh
Copy link
Member

We have a way to exclude rules from that check -- I will add it.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh enabled auto-merge (squash) May 10, 2024 19:03
@charliermarsh charliermarsh merged commit 0726e82 into astral-sh:main May 10, 2024
19 checks passed
@dougthor42 dougthor42 deleted the f541-doc-gh11357 branch May 11, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants