Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid PLE0237 for property with setter #11377

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

dhruvmanila
Copy link
Member

Summary

Should this consider the decorator only if the name is actually a property or is the logic in this PR correct?

fixes: #11358

Test Plan

Add test case.

@dhruvmanila dhruvmanila added the bug Something isn't working label May 12, 2024
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

@charliermarsh charliermarsh merged commit 0fc6cf9 into main May 13, 2024
19 checks passed
@charliermarsh charliermarsh deleted the dhruv/setter-PLE0237 branch May 13, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PLE0237 unaware of properties with setter
2 participants