Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes invalid rule from hyphen #11484

Merged
merged 1 commit into from
May 22, 2024

Conversation

ekohilas
Copy link
Contributor

Summary

When using add_rule.py, it produces the following line in codes.rs

        (Flake8Async, "102") => (RuleGroup::Stable, rules::flake8-async::rules::BlockingOsCallInAsyncFunction),

Causing a syntax error.

This PR resolves that issue so that the script can be used again.

Test Plan

Tested manually in new rule creation

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@ekohilas ekohilas marked this pull request as ready for review May 21, 2024 21:18
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh added documentation Improvements or additions to documentation internal An internal refactor or improvement and removed documentation Improvements or additions to documentation labels May 22, 2024
@charliermarsh charliermarsh merged commit 3476e2f into astral-sh:main May 22, 2024
19 checks passed
@charliermarsh
Copy link
Member

I think there's high likelihood that there are other bugs and limitations in those scripts; they're not tested continuously so they tend to go stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants