-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pylint] redefined-loop-name (W2901) #3022
Merged
charliermarsh
merged 12 commits into
astral-sh:main
from
matthewlloyd:pylint-redefined-loop-name
Feb 22, 2023
Merged
[pylint] redefined-loop-name (W2901) #3022
charliermarsh
merged 12 commits into
astral-sh:main
from
matthewlloyd:pylint-redefined-loop-name
Feb 22, 2023
Commits on Feb 19, 2023
-
[pylint] redefined-loop-name (W2901)
Slightly broadens W2901 to cover `with` statements too. Closes #2972.
Configuration menu - View commit details
-
Copy full SHA for 9923004 - Browse repository at this point
Copy the full SHA 9923004View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c77a42 - Browse repository at this point
Copy the full SHA 4c77a42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76ea0eb - Browse repository at this point
Copy the full SHA 76ea0ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for b89639b - Browse repository at this point
Copy the full SHA b89639bView commit details -
Merge remote-tracking branch 'matthewlloyd/pylint-redefined-loop-name…
…' into pylint-redefined-loop-name
Configuration menu - View commit details
-
Copy full SHA for b1b40c1 - Browse repository at this point
Copy the full SHA b1b40c1View commit details -
Address review comments: narrow the error message
Examples: ``` test.py:2:9: PLW2901 Outer for loop variable `i` overwritten by for loop target with same name test.py:6:9: PLW2901 Outer with statement variable `i` overwritten by for loop target with same name test.py:12:5: PLW2901 Outer for loop variable `i` overwritten by assignment target with same name ```
Configuration menu - View commit details
-
Copy full SHA for 1445766 - Browse repository at this point
Copy the full SHA 1445766View commit details
Commits on Feb 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d2f0042 - Browse repository at this point
Copy the full SHA d2f0042View commit details
Commits on Feb 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e3fcc32 - Browse repository at this point
Copy the full SHA e3fcc32View commit details
Commits on Feb 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7d02535 - Browse repository at this point
Copy the full SHA 7d02535View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70162e1 - Browse repository at this point
Copy the full SHA 70162e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddd2ac8 - Browse repository at this point
Copy the full SHA ddd2ac8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e577e16 - Browse repository at this point
Copy the full SHA e577e16View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.