fix(isort): comply with isort when sorting sub-package modules #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaceone
force-pushed
the
3059-isort-package-sorting
branch
from
7f8755c
to
ca3ca4a
Compare
| } else if known_local_folder.contains(module_name) { | ||
| (ImportType::LocalFolder, Reason::KnownLocalFolder) | ||
| } else if extra_standard_library.contains(module_name) { | ||
| (ImportType::StandardLibrary, Reason::ExtraStandardLibrary) |
There was a problem hiding this comment.
What does isort do if you have:
known-first-party = ["foo"]
known-third-party = ["foo.bar"]
And then you import foo.bar.baz. Does that get classified as first- or third-party?
There was a problem hiding this comment.
[settings]
known_first_party=foo
known_third_party=foo.barresults in:
import sys
import foo.bar
import foo.bar.baz
from foo.bar import blah, blub
from foo.bar.baz import something
import foo
from foo import bar, bazSo my MR currently has this diff:
ruff --select I --fix --diff foo.py
--- foo.py
+++ foo.py
@@ -1,9 +1,9 @@
import sys
import foo.bar
-import foo.bar.baz
from foo.bar import blah, blub
-from foo.bar.baz import something
import foo
+import foo.bar.baz
from foo import bar, baz
+from foo.bar.baz import something
Would fix 1 error.
spaceone
force-pushed
the
3059-isort-package-sorting
branch
from
ca3ca4a
to
594a8f5
Compare
e.g. packages named "foo.bar" additionally make sure `__future__` imports are always sorted at the very top. Issue astral-sh#3059
spaceone
force-pushed
the
3059-isort-package-sorting
branch
from
594a8f5
to
941e0d2
Compare
|
I'm going to close this for now, just to keep the open PR list tight. If you choose to return to this, we can always reopen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. packages named "foo.bar"
additionally make sure
__future__imports are always sorted at the very top.Fixes #3059