Scope and Binding IDs

[MichaReiser]

This PR introduces the new ScopeId and BindingId types instead of using the generic usize type.

Using a specific type allows us to enforce that bindings and scopes can only be indexed with the corresponding id-types, reducing the risk that they get mixed up. To do this, I had to introduce new Scopes, Bindings and ScopeStack wrapper types.

This PR removes the AtomicUsize that computes the next scope id and instead uses scopes.len() to compute the next id.

[MichaReiser]

Current dependencies on/for this PR:

• main
  • PR Scope and Binding IDs #3572 👈
    • PR refactor: Move scope and binding types to scope.rs #3573
      • PR Make scope.bindings private #3575

This comment was auto-generated by Graphite.

[MichaReiser]

I moved all these types to a scope.rs in the following PR

[github-actions]

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                        main                                   pr
-----                        ----                                   --
linter/large/dataset.py      1.01      8.6±0.06ms     4.7 MB/sec    1.00      8.5±0.07ms     4.8 MB/sec
linter/numpy/ctypeslib.py    1.03      2.3±0.01ms   152.3 MB/sec    1.00      2.2±0.01ms   157.5 MB/sec
linter/numpy/globals.py      1.03   1134.6±6.01µs   157.1 MB/sec    1.00   1104.3±3.29µs   161.4 MB/sec
linter/pydantic/types.py     1.01      3.9±0.02ms     6.5 MB/sec    1.00      3.9±0.01ms     6.6 MB/sec

Windows

group                        main                                   pr
-----                        ----                                   --
linter/large/dataset.py      1.00      8.8±0.09ms     4.6 MB/sec    1.01      8.9±0.20ms     4.6 MB/sec
linter/numpy/ctypeslib.py    1.00      2.3±0.03ms   149.0 MB/sec    1.03      2.4±0.03ms   145.4 MB/sec
linter/numpy/globals.py      1.00  1177.3±26.31µs   151.4 MB/sec    1.01  1193.0±23.48µs   149.4 MB/sec
linter/pydantic/types.py     1.00      4.1±0.08ms     6.2 MB/sec    1.01      4.1±0.09ms     6.2 MB/sec

[charliermarsh]

Great change, big improvement.