Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo test --doc #3766

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Fix cargo test --doc #3766

merged 1 commit into from
Mar 28, 2023

Conversation

konstin
Copy link
Member

@konstin konstin commented Mar 28, 2023

See #3752 (comment)

I don't understand why this didn't show up earlier, i thought cargo test would include cargo test --doc

@konstin konstin marked this pull request as ready for review March 28, 2023 11:30
@konstin konstin enabled auto-merge (squash) March 28, 2023 11:33
@konstin konstin merged commit 756e995 into astral-sh:main Mar 28, 2023
12 checks passed
@MichaReiser
Copy link
Member

MichaReiser commented Mar 28, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     16.3±0.12ms     2.5 MB/sec    1.00     16.3±0.12ms     2.5 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.2±0.03ms     4.0 MB/sec    1.00      4.2±0.04ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.00    552.7±4.35µs     5.3 MB/sec    1.00    553.6±3.62µs     5.3 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.0±0.05ms     3.6 MB/sec    1.00      7.0±0.05ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.01      8.5±0.05ms     4.8 MB/sec    1.00      8.4±0.06ms     4.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1927.0±13.30µs     8.6 MB/sec    1.00  1923.5±10.21µs     8.7 MB/sec
linter/default-rules/numpy/globals.py      1.00    214.0±2.12µs    13.8 MB/sec    1.00    214.3±2.75µs    13.8 MB/sec
linter/default-rules/pydantic/types.py     1.01      4.0±0.03ms     6.4 MB/sec    1.00      3.9±0.03ms     6.5 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.06     20.2±0.89ms     2.0 MB/sec    1.00     19.1±1.01ms     2.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.06      5.0±0.17ms     3.3 MB/sec    1.00      4.7±0.19ms     3.5 MB/sec
linter/all-rules/numpy/globals.py          1.05   625.4±21.02µs     4.7 MB/sec    1.00   595.7±28.63µs     5.0 MB/sec
linter/all-rules/pydantic/types.py         1.05      8.3±0.46ms     3.1 MB/sec    1.00      7.9±0.32ms     3.2 MB/sec
linter/default-rules/large/dataset.py      1.07     10.0±0.44ms     4.1 MB/sec    1.00      9.3±0.31ms     4.4 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.05      2.2±0.10ms     7.4 MB/sec    1.00      2.1±0.11ms     7.8 MB/sec
linter/default-rules/numpy/globals.py      1.00    242.7±9.71µs    12.2 MB/sec    1.03   250.9±11.91µs    11.8 MB/sec
linter/default-rules/pydantic/types.py     1.01      4.4±0.18ms     5.8 MB/sec    1.00      4.4±0.24ms     5.9 MB/sec

@konstin konstin deleted the fix_cargo_test_doc branch March 28, 2023 11:54
@konstin
Copy link
Member Author

konstin commented Mar 28, 2023

oh interesting! The source is #1772. Though now i'm even more confused as to why cargo test --doc ignores the flag

@MichaReiser
Copy link
Member

oh interesting! The source is #1772. Though now i'm even more confused as to why cargo test --doc ignores the flag

I understand the doctest=false configuration tells cargo this crate has no doctests. Meaning, it's not necessary to parse the files, extract and compile the doctests for this crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants